summaryrefslogtreecommitdiffstats
path: root/include/linux
diff options
context:
space:
mode:
authorPavan Savoy <pavan_savoy@ti.com>2010-10-12 16:27:38 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-10-14 12:41:10 -0700
commit73f12e8d3d94828b9efe2b8b8a34b4ad6d14ee47 (patch)
tree42b4dad70d74feccd5c6c802eef6837606096ffe /include/linux
parentda6830ac3969c9480e05ed2b21eee64e21a101d2 (diff)
downloadop-kernel-dev-73f12e8d3d94828b9efe2b8b8a34b4ad6d14ee47.zip
op-kernel-dev-73f12e8d3d94828b9efe2b8b8a34b4ad6d14ee47.tar.gz
drivers: misc: ti-st: fix review comments
Based on comments from Jiri Slaby, drop the register storage specifier, remove the unused code, cleanup the const to non-const type casting. Also make the line discipline ops structure static, since its a singleton, unmodified structure which need not be in heap. Reported-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: Pavan Savoy <pavan_savoy@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include/linux')
-rw-r--r--include/linux/ti_wilink_st.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/ti_wilink_st.h b/include/linux/ti_wilink_st.h
index 2a5acf5..4c7be22 100644
--- a/include/linux/ti_wilink_st.h
+++ b/include/linux/ti_wilink_st.h
@@ -101,7 +101,6 @@ extern long st_unregister(enum proto_type);
* can occur , where as during other times other events CH8, CH9
* can occur.
* @tty: tty provided by the TTY core for line disciplines.
- * @ldisc_ops: the procedures that this line discipline registers with TTY.
* @tx_skb: If for some reason the tty's write returns lesser bytes written
* then to maintain the rest of data to be written on next instance.
* This needs to be protected, hence the lock inside wakeup func.
@@ -132,7 +131,6 @@ extern long st_unregister(enum proto_type);
struct st_data_s {
unsigned long st_state;
struct tty_struct *tty;
- struct tty_ldisc_ops *ldisc_ops;
struct sk_buff *tx_skb;
#define ST_TX_SENDING 1
#define ST_TX_WAKEUP 2
OpenPOWER on IntegriCloud