diff options
| author | Jeff Layton <jlayton@primarydata.com> | 2014-11-21 14:19:29 -0500 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2014-12-09 11:22:22 -0500 |
| commit | 403c7b44441d60aba7f8a134c31279ffa60ea769 (patch) | |
| tree | 97005025d0e50119a720f8a29672d3b695ff7886 /include/linux/sunrpc | |
| parent | 812443865c5fc255363d4a684a62c086af1addca (diff) | |
| download | op-kernel-dev-403c7b44441d60aba7f8a134c31279ffa60ea769.zip op-kernel-dev-403c7b44441d60aba7f8a134c31279ffa60ea769.tar.gz | |
sunrpc: fix potential races in pool_stats collection
In a later patch, we'll be removing some spinlocking around the socket
and thread queueing code in order to fix some contention problems. At
that point, the stats counters will no longer be protected by the
sp_lock.
Change the counters to atomic_long_t fields, except for the
"sockets_queued" counter which will still be manipulated under a
spinlock.
Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Tested-by: Chris Worley <chris.worley@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'include/linux/sunrpc')
| -rw-r--r-- | include/linux/sunrpc/svc.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h index 7f80a99..513957e 100644 --- a/include/linux/sunrpc/svc.h +++ b/include/linux/sunrpc/svc.h @@ -26,10 +26,10 @@ typedef int (*svc_thread_fn)(void *); /* statistics for svc_pool structures */ struct svc_pool_stats { - unsigned long packets; + atomic_long_t packets; unsigned long sockets_queued; - unsigned long threads_woken; - unsigned long threads_timedout; + atomic_long_t threads_woken; + atomic_long_t threads_timedout; }; /* |
