diff options
author | Kim, Milo <Milo.Kim@ti.com> | 2012-08-31 09:23:03 +0000 |
---|---|---|
committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-09-20 17:55:34 -0700 |
commit | fb9adc5190d7605506ebc0e05351baa57365cc90 (patch) | |
tree | 4b84b79e2c0abc2de7a9513a3aaaa7f884effae3 /include/linux/platform_data/lp8727.h | |
parent | 74727c571517692ae24d0562676f2c61a86b9090 (diff) | |
download | op-kernel-dev-fb9adc5190d7605506ebc0e05351baa57365cc90.zip op-kernel-dev-fb9adc5190d7605506ebc0e05351baa57365cc90.tar.gz |
lp8727_charger: Cleanup _probe() and _remove()
If the lp8727_register_psy() gets failed, registered interrupt handler
should be freed, but this is not complete solution. It has still problem.
Assume that the IRQ occurs while unregistering power supply devices. Then
the ISR will access to freed IRQ.
From Anton's opinion, it can be resolved if re-ordering the call sequence.
Register power supplies first, then create interrupt handler. Then no need
to free the IRQ in _probe(). Additionally goto statements can be removed
because those can be replaced with return statements.
The _remove() should be changed the sequence - in reverse order of
_probe()
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'include/linux/platform_data/lp8727.h')
0 files changed, 0 insertions, 0 deletions