summaryrefslogtreecommitdiffstats
path: root/include/linux/pktcdvd.h
diff options
context:
space:
mode:
authorPeter Osterlund <petero2@telia.com>2006-02-04 23:27:47 -0800
committerLinus Torvalds <torvalds@g5.osdl.org>2006-02-05 11:06:52 -0800
commite1bc89bc9991e994f2b3c60d9ad2fdb5ad9b10fc (patch)
tree22816d5b1979961ec60507e8b6783a02c7fdb283 /include/linux/pktcdvd.h
parentb566ccefd7814e4fa403de81aea299bdc11ceed5 (diff)
downloadop-kernel-dev-e1bc89bc9991e994f2b3c60d9ad2fdb5ad9b10fc.zip
op-kernel-dev-e1bc89bc9991e994f2b3c60d9ad2fdb5ad9b10fc.tar.gz
[PATCH] pktcdvd: Don't waste kernel memory
Allocate memory for read-gathering at open time, when it is known just how much memory is needed. This avoids wasting kernel memory when the real packet size is smaller than the maximum packet size supported by the driver. This is always the case when using DVD discs. Signed-off-by: Peter Osterlund <petero2@telia.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux/pktcdvd.h')
-rw-r--r--include/linux/pktcdvd.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
index d1c9c4a..1623da8 100644
--- a/include/linux/pktcdvd.h
+++ b/include/linux/pktcdvd.h
@@ -170,7 +170,7 @@ struct packet_iosched
#error "PAGE_SIZE must be a multiple of CD_FRAMESIZE"
#endif
#define PACKET_MAX_SIZE 32
-#define PAGES_PER_PACKET (PACKET_MAX_SIZE * CD_FRAMESIZE / PAGE_SIZE)
+#define FRAMES_PER_PAGE (PAGE_SIZE / CD_FRAMESIZE)
#define PACKET_MAX_SECTORS (PACKET_MAX_SIZE * CD_FRAMESIZE >> 9)
enum packet_data_state {
@@ -219,7 +219,7 @@ struct packet_data
atomic_t io_errors; /* Number of read/write errors during IO */
struct bio *r_bios[PACKET_MAX_SIZE]; /* bios to use during data gathering */
- struct page *pages[PAGES_PER_PACKET];
+ struct page *pages[PACKET_MAX_SIZE / FRAMES_PER_PAGE];
int cache_valid; /* If non-zero, the data for the zone defined */
/* by the sector variable is completely cached */
OpenPOWER on IntegriCloud