diff options
| author | Tejun Heo <tj@kernel.org> | 2013-06-12 20:52:01 -0700 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2013-06-13 11:08:26 -0700 |
| commit | acac7883ee7bcc32476963bce7baf73d44574dd1 (patch) | |
| tree | 1ac595ff0f048b4beb74fd59819233b066c2d2f2 /include/linux/percpu-refcount.h | |
| parent | ac899061a93250c28562f05ad94d5c74603415bc (diff) | |
| download | op-kernel-dev-acac7883ee7bcc32476963bce7baf73d44574dd1.zip op-kernel-dev-acac7883ee7bcc32476963bce7baf73d44574dd1.tar.gz | |
percpu-refcount: add __must_check to percpu_ref_init() and don't use ACCESS_ONCE() in percpu_ref_kill_rcu()
Two small changes.
* Unlike most init functions, percpu_ref_init() allocates memory and
may fail. Let's mark it with __must_check in case the caller
forgets.
* percpu_ref_kill_rcu() is unnecessarily using ACCESS_ONCE() to
dereference @ref->pcpu_count, which can be misleading. The pointer
is guaranteed to be valid and visible and can't change underneath
the function. Drop ACCESS_ONCE().
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'include/linux/percpu-refcount.h')
| -rw-r--r-- | include/linux/percpu-refcount.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h index b61bd6f..8146aa9 100644 --- a/include/linux/percpu-refcount.h +++ b/include/linux/percpu-refcount.h @@ -66,7 +66,8 @@ struct percpu_ref { struct rcu_head rcu; }; -int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release); +int __must_check percpu_ref_init(struct percpu_ref *ref, + percpu_ref_func_t *release); void percpu_ref_kill(struct percpu_ref *ref); #define PCPU_STATUS_BITS 2 |
