diff options
| author | Jens Frederich <jfrederich@gmail.com> | 2013-08-15 21:34:55 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-08-15 17:22:27 -0700 |
| commit | 98d4f93c79b002f85480320fe63fefaa31d58b6c (patch) | |
| tree | 0bd102d568f888d5e1eb4e359018211851bf93fd /include/linux/olpc-ec.h | |
| parent | 01f865ba4a1ee95d4828b4f3fa69d68f9ac4b9ba (diff) | |
| download | op-kernel-dev-98d4f93c79b002f85480320fe63fefaa31d58b6c.zip op-kernel-dev-98d4f93c79b002f85480320fe63fefaa31d58b6c.tar.gz | |
Staging: olpc_dcon: replace some magic numbers
This patch replace some magic numbers. I believe it makes
the driver more readable.
The magic number 0x26 is the XO system embedded controller
(EC) command 'DCON power enable/disable'.
Number 0x41, and 0x42 are special memory controller settings
register. The 0x41 initialize bit sequence 0x101 means:
enable memory power down function and special SDRAM clock
delay for synchronize SDRAM output and clock signal.
The 0x42 initialize squence 0x101 is wrong. According to
the specification Bit 8 is reserved, thus not in use.
I removed it.
Signed-off-by: Jens Frederich <jfrederich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/olpc-ec.h')
| -rw-r--r-- | include/linux/olpc-ec.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h index 5bb6e76..2925df3 100644 --- a/include/linux/olpc-ec.h +++ b/include/linux/olpc-ec.h @@ -6,6 +6,7 @@ #define EC_WRITE_SCI_MASK 0x1b #define EC_WAKE_UP_WLAN 0x24 #define EC_WLAN_LEAVE_RESET 0x25 +#define EC_DCON_POWER_MODE 0x26 #define EC_READ_EB_MODE 0x2a #define EC_SET_SCI_INHIBIT 0x32 #define EC_SET_SCI_INHIBIT_RELEASE 0x34 |
