diff options
author | Steven Rostedt <srostedt@redhat.com> | 2009-03-21 02:44:50 -0400 |
---|---|---|
committer | Steven Rostedt <srostedt@redhat.com> | 2009-03-24 09:07:35 -0400 |
commit | 098335215a4921a8a54193829eaed602dca24df5 (patch) | |
tree | 86226d7e4229f00e467b5e6ed7f048a2061c3042 /include/linux/ftrace.h | |
parent | 45b9560895b07a4a09d55d49235c984db512c5aa (diff) | |
download | op-kernel-dev-098335215a4921a8a54193829eaed602dca24df5.zip op-kernel-dev-098335215a4921a8a54193829eaed602dca24df5.tar.gz |
tracing: fix memory leak in trace_stat
If the function profiler does not have any items recorded and one were
to cat the function stat file, the kernel would take a BUG with a NULL
pointer dereference.
Looking further into this, I found that returning NULL from stat_start
did not stop the stat logic, and would later call stat_next. This breaks
from the way seq_file works, so I looked into fixing the stat code.
This is where I noticed that the last next_entry is never freed.
It is allocated, and if the stat_next returns NULL, the code breaks out
of the loop, unlocks the mutex and exits. We never link the next_entry
nor do we free it. Thus it is a real memory leak.
This patch rearranges the code a bit to not only fix the memory leak,
but also to act more like seq_file where nothing is printed if there
is nothing to print. That is, stat_start returns NULL.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Diffstat (limited to 'include/linux/ftrace.h')
0 files changed, 0 insertions, 0 deletions