diff options
| author | Bob Breuer <breuerr@mc.net> | 2007-02-01 20:24:35 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-02-01 20:24:35 -0800 |
| commit | 51bcf092917bfaa88d762879d0bbfe7619e8c16c (patch) | |
| tree | 637ebcb8992b5358d142b8400fce25f5f82f0bcc /include/asm-sparc/checksum.h | |
| parent | e34efe3b100d0fbdf053128956c3dd0bc68754d6 (diff) | |
| download | op-kernel-dev-51bcf092917bfaa88d762879d0bbfe7619e8c16c.zip op-kernel-dev-51bcf092917bfaa88d762879d0bbfe7619e8c16c.tar.gz | |
[SPARC32]: Fix over-optimization by GCC near ip_fast_csum.
In some cases such as:
iph->check = 0;
iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
GCC may optimize out the previous store.
Observed as a failure of NFS over udp (bad checksums on ip fragments)
when compiled with GCC 3.4.2.
Signed-off-by: Bob Breuer <breuerr@mc.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/asm-sparc/checksum.h')
| -rw-r--r-- | include/asm-sparc/checksum.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/asm-sparc/checksum.h b/include/asm-sparc/checksum.h index 267e631..34518ea 100644 --- a/include/asm-sparc/checksum.h +++ b/include/asm-sparc/checksum.h @@ -151,7 +151,7 @@ static inline __sum16 ip_fast_csum(const void *iph, unsigned int ihl) "xnor\t%%g0, %0, %0" : "=r" (sum), "=&r" (iph) : "r" (ihl), "1" (iph) - : "g2", "g3", "g4", "cc"); + : "g2", "g3", "g4", "cc", "memory"); return sum; } |
