diff options
| author | Roland McGrath <roland@redhat.com> | 2005-05-26 15:21:13 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-05-26 16:16:16 -0700 |
| commit | d68b8622ccbee8a18e495ad1650c3306f2eeb0d6 (patch) | |
| tree | 7ec334394d78055de4d085c354c2931390c229f0 /include/asm-i386 | |
| parent | 4ec5240ec367a592834385893200dd4fb369354c (diff) | |
| download | op-kernel-dev-d68b8622ccbee8a18e495ad1650c3306f2eeb0d6.zip op-kernel-dev-d68b8622ccbee8a18e495ad1650c3306f2eeb0d6.tar.gz | |
[PATCH] i386: fix prevent_tail_call
We fixed this bug before, but it didn't take. It may have been the case
that the problem was first noticed to occur in a CONFIG_REGPARM compile.
But it's not regparm functions that need not to make tail calls, it's
asmlinkage functions called with a user pt_regs frame on the stack
supplying their arguments. prevent_tail_call probably doesn't do anything
at all in regparm functions (your argument registers are going to be
clobbered, period). It was a braino to conditionalize that definition in
the first place.
Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/asm-i386')
| -rw-r--r-- | include/asm-i386/linkage.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/include/asm-i386/linkage.h b/include/asm-i386/linkage.h index af3d857..f4a6eba 100644 --- a/include/asm-i386/linkage.h +++ b/include/asm-i386/linkage.h @@ -5,9 +5,7 @@ #define FASTCALL(x) x __attribute__((regparm(3))) #define fastcall __attribute__((regparm(3))) -#ifdef CONFIG_REGPARM -# define prevent_tail_call(ret) __asm__ ("" : "=r" (ret) : "0" (ret)) -#endif +#define prevent_tail_call(ret) __asm__ ("" : "=r" (ret) : "0" (ret)) #ifdef CONFIG_X86_ALIGNMENT_16 #define __ALIGN .align 16,0x90 |
