summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorMark Fasheh <mark.fasheh@oracle.com>2008-02-28 17:16:03 -0800
committerMark Fasheh <mark.fasheh@oracle.com>2008-03-03 15:50:21 -0800
commit1044e401af9a309637828aa3cc8f3b6409fcbf4e (patch)
tree1da79829e1afa048b5e9e45c32470bbd75e49084 /fs
parent7ad8b3d30ecae325fcccbf86f34ce3af716b4f95 (diff)
downloadop-kernel-dev-1044e401af9a309637828aa3cc8f3b6409fcbf4e.zip
op-kernel-dev-1044e401af9a309637828aa3cc8f3b6409fcbf4e.tar.gz
ocfs2: Fix writeout in ocfs2_data_convert_worker()
Commit f1f540688eae66c274ff1c1133b5d9c687b28f58 "optimized" ocfs2_data_convert_worker() to "only do work for regular files". Unfortunately, I left out a '!', which casued it to *skip* regular files. This was hidden from testing until recently because the default data journaling mode (data=ordered) doesn't exercise this code. Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com> Signed-off-by: Joel Becker <joel.becker@oracle.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/ocfs2/dlmglue.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 351130c..f4b3dab 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -3042,7 +3042,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
inode = ocfs2_lock_res_inode(lockres);
mapping = inode->i_mapping;
- if (S_ISREG(inode->i_mode))
+ if (!S_ISREG(inode->i_mode))
goto out;
/*
OpenPOWER on IntegriCloud