summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorKinglong Mee <kinglongmee@gmail.com>2013-12-23 17:31:21 +0800
committerJ. Bruce Fields <bfields@redhat.com>2014-01-03 18:18:47 -0500
commitf403e450e85cd403b63fd163d29b6b7f5e8eaf77 (patch)
tree971d4893a058fedca25f24e6710d901edac51a65 /fs
parent2ce02b6b6cf3532df143b85a72bacd611a55616a (diff)
downloadop-kernel-dev-f403e450e85cd403b63fd163d29b6b7f5e8eaf77.zip
op-kernel-dev-f403e450e85cd403b63fd163d29b6b7f5e8eaf77.tar.gz
NFSD: fix a leak which can cause CREATE_SESSION failures
check_forechannel_attrs gets drc memory, so nfsd must put it when check_backchannel_attrs fails. After many requests with bad back channel attrs, nfsd will deny any client's CREATE_SESSION forever. A new test case named CSESS29 for pynfs will send in another mail. Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/nfsd/nfs4state.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 1aed9be..9a6d088 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1915,7 +1915,7 @@ nfsd4_create_session(struct svc_rqst *rqstp,
return status;
status = check_backchannel_attrs(&cr_ses->back_channel);
if (status)
- return status;
+ goto out_release_drc_mem;
status = nfserr_jukebox;
new = alloc_session(&cr_ses->fore_channel);
if (!new)
OpenPOWER on IntegriCloud