diff options
| author | Sage Weil <sage@newdream.net> | 2010-02-02 16:34:04 -0800 |
|---|---|---|
| committer | Sage Weil <sage@newdream.net> | 2010-02-02 16:34:04 -0800 |
| commit | 79788c698b290426320e60374ed1324e4b5c69eb (patch) | |
| tree | 6c96d36c99c043c04c1d4c8686639f67f71232ba /fs | |
| parent | 0c948992a00d478c17042f4790b7d6b35299cf94 (diff) | |
| download | op-kernel-dev-79788c698b290426320e60374ed1324e4b5c69eb.zip op-kernel-dev-79788c698b290426320e60374ed1324e4b5c69eb.tar.gz | |
ceph: release all pages after successful osd write response
We release all the pages, even if the osd response was
different than the number of pages written. This could only
happen due to truncation that arrives the osd in
different order, for which we want the pages released anyway.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ceph/addr.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index a3bd9de..8065dc9 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -524,9 +524,13 @@ static void writepages_finish(struct ceph_osd_request *req, bytes = le64_to_cpu(op->extent.length); if (rc >= 0) { - wrote = (bytes + (offset & ~PAGE_CACHE_MASK) + ~PAGE_CACHE_MASK) - >> PAGE_CACHE_SHIFT; - WARN_ON(wrote != req->r_num_pages); + /* + * Assume we wrote the pages we originally sent. The + * osd might reply with fewer pages if our writeback + * raced with a truncation and was adjusted at the osd, + * so don't believe the reply. + */ + wrote = req->r_num_pages; } else { wrote = 0; mapping_set_error(mapping, rc); |
