diff options
| author | Kulikov Vasiliy <segooon@gmail.com> | 2010-07-20 17:54:28 +1000 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2010-07-26 13:16:50 -0500 |
| commit | 3f34885cd7c6a3f4deea48e3bbc704d91d5704f4 (patch) | |
| tree | c03bcdaf42d70d7e08df2cd629d5308870660bed /fs | |
| parent | aea1b9532143218f8599ecedbbd6bfbf812385e1 (diff) | |
| download | op-kernel-dev-3f34885cd7c6a3f4deea48e3bbc704d91d5704f4.zip op-kernel-dev-3f34885cd7c6a3f4deea48e3bbc704d91d5704f4.tar.gz | |
xfs: fix unsigned underflow in xfs_free_eofblocks
map_len is unsigned. Checking map_len <= 0 is buggy when it should be
below zero. So, check exact expression instead of map_len.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/xfs/xfs_vnodeops.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index 9865e11..3ac137d 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c @@ -589,9 +589,9 @@ xfs_free_eofblocks( */ end_fsb = XFS_B_TO_FSB(mp, ((xfs_ufsize_t)ip->i_size)); last_fsb = XFS_B_TO_FSB(mp, (xfs_ufsize_t)XFS_MAXIOFFSET(mp)); - map_len = last_fsb - end_fsb; - if (map_len <= 0) + if (last_fsb <= end_fsb) return 0; + map_len = last_fsb - end_fsb; nimaps = 1; xfs_ilock(ip, XFS_ILOCK_SHARED); |
