summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2013-10-01 13:11:21 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2013-10-01 13:11:21 -0400
commitc2d22ecd3cf3c49aeecdc10ffd7af10ec1f7eab6 (patch)
treecb180b5926c4b81a4385f785c7f0b856f8620fcd /fs
parent13f3583892cb7afdb2e9eb0207dc4e03ec6f01fd (diff)
downloadop-kernel-dev-c2d22ecd3cf3c49aeecdc10ffd7af10ec1f7eab6.zip
op-kernel-dev-c2d22ecd3cf3c49aeecdc10ffd7af10ec1f7eab6.tar.gz
fs/super.c: fix lru_list leak for real
Freeing ->s_{inode,dentry}_lru in deactivate_locked_super() is wrong; the right place is destroy_super(). As it is, we leak them if sget() decides that new superblock it has allocated (and never shown to anybody) isn't needed and should be freed. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r--fs/super.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/super.c b/fs/super.c
index 3a96c97..0225c20 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -264,6 +264,8 @@ out_free_sb:
*/
static inline void destroy_super(struct super_block *s)
{
+ list_lru_destroy(&s->s_dentry_lru);
+ list_lru_destroy(&s->s_inode_lru);
#ifdef CONFIG_SMP
free_percpu(s->s_files);
#endif
@@ -323,8 +325,6 @@ void deactivate_locked_super(struct super_block *s)
/* caches are now gone, we can safely kill the shrinker now */
unregister_shrinker(&s->s_shrink);
- list_lru_destroy(&s->s_dentry_lru);
- list_lru_destroy(&s->s_inode_lru);
put_filesystem(fs);
put_super(s);
OpenPOWER on IntegriCloud