summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorPeng Tao <bergwolf@gmail.com>2009-08-10 23:05:28 -0400
committerTheodore Ts'o <tytso@mit.edu>2009-08-10 23:05:28 -0400
commit91cc219ad963731191247c5f2db4118be2bc341a (patch)
treea00e1c0b8a773f88bcb3ae81758ec4528b73405d /fs
parentb1f485f20eb9b02cc7d2009556287f3939d480cc (diff)
downloadop-kernel-dev-91cc219ad963731191247c5f2db4118be2bc341a.zip
op-kernel-dev-91cc219ad963731191247c5f2db4118be2bc341a.tar.gz
ext4: fix journal ref count in move_extent_par_page
move_extent_par_page calls a_ops->write_begin() to increase journal handler's reference count. However, if either mext_replace_branches() or ext4_get_block fails, the increased reference count isn't decreased. This will cause a later attempt to umount of the fs to hang forever. The patch addresses the issue by calling ext4_journal_stop() if page is not NULL (which means a_ops->write_end() isn't invoked). Signed-off-by: Peng Tao <bergwolf@gmail.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext4/move_extent.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index bbf2dd9..5821e0b 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -871,6 +871,7 @@ out:
if (PageLocked(page))
unlock_page(page);
page_cache_release(page);
+ ext4_journal_stop(handle);
}
out2:
ext4_journal_stop(handle);
OpenPOWER on IntegriCloud