summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorYan, Zheng <zheng.z.yan@intel.com>2012-09-20 17:42:25 +0800
committerAlex Elder <elder@inktank.com>2012-10-01 14:30:54 -0500
commit3e8f43a089f06279c5f76a9ccd42578eebf7bfa5 (patch)
tree5b208f18d8a3031b21ed379bca471dbf2fdb0e47 /fs
parent6e14b1a6c3b8d7e48ece68733d2dac0464611ee4 (diff)
downloadop-kernel-dev-3e8f43a089f06279c5f76a9ccd42578eebf7bfa5.zip
op-kernel-dev-3e8f43a089f06279c5f76a9ccd42578eebf7bfa5.tar.gz
ceph: Fix oops when handling mdsmap that decreases max_mds
When i >= newmap->m_max_mds, ceph_mdsmap_get_addr(newmap, i) return NULL. Passing NULL to memcmp() triggers oops. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Signed-off-by: Sage Weil <sage@inktank.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/ceph/mds_client.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index a5a7354..1bcf712 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -2625,7 +2625,8 @@ static void check_new_map(struct ceph_mds_client *mdsc,
ceph_mdsmap_is_laggy(newmap, i) ? " (laggy)" : "",
session_state_name(s->s_state));
- if (memcmp(ceph_mdsmap_get_addr(oldmap, i),
+ if (i >= newmap->m_max_mds ||
+ memcmp(ceph_mdsmap_get_addr(oldmap, i),
ceph_mdsmap_get_addr(newmap, i),
sizeof(struct ceph_entity_addr))) {
if (s->s_state == CEPH_MDS_SESSION_OPENING) {
OpenPOWER on IntegriCloud