summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorDavid Woodhouse <dwmw2@infradead.org>2007-05-08 00:12:58 +0100
committerDavid Woodhouse <dwmw2@infradead.org>2007-05-20 11:30:38 -0400
commit2ad8ee713566671875216ebcec64f2eda47bd19d (patch)
treeb8ad57ea0041b66b68eae2bb089f0c70b13a7ab9 /fs
parent8ae5d31263c746f1680d005b33a82d167cdb9eb6 (diff)
downloadop-kernel-dev-2ad8ee713566671875216ebcec64f2eda47bd19d.zip
op-kernel-dev-2ad8ee713566671875216ebcec64f2eda47bd19d.tar.gz
[JFFS2] Fix potential memory leak of dead xattrs on unmount.
An xattr_datum which ends up orphaned should be freed by the GC thread. But if we umount before the GC thread is finished, or if we mount read-only and the GC thread never runs, they might never be freed. Clean them up during unmount, if there are any left. Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/jffs2/xattr.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c
index 0734698..e486659 100644
--- a/fs/jffs2/xattr.c
+++ b/fs/jffs2/xattr.c
@@ -754,6 +754,10 @@ void jffs2_clear_xattr_subsystem(struct jffs2_sb_info *c)
list_del(&xd->xindex);
jffs2_free_xattr_datum(xd);
}
+ list_for_each_entry_safe(xd, _xd, &c->xattr_unchecked, xindex) {
+ list_del(&xd->xindex);
+ jffs2_free_xattr_datum(xd);
+ }
}
#define XREF_TMPHASH_SIZE (128)
OpenPOWER on IntegriCloud