summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorYan <yanzheng@21cn.com>2008-04-01 11:21:34 -0400
committerChris Mason <chris.mason@oracle.com>2008-09-25 11:04:01 -0400
commite58ca0203d32869a01540a293df40ddc480dc378 (patch)
treea0a7c4f66d296ea9dd12d13f2c9e7531401b96bf /fs
parent63b10fc4874a014e22bc4c64e3d92b71180661fe (diff)
downloadop-kernel-dev-e58ca0203d32869a01540a293df40ddc480dc378.zip
op-kernel-dev-e58ca0203d32869a01540a293df40ddc480dc378.tar.gz
Fix btrfs_fill_super to return -EINVAL when no FS found
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/btrfs/disk-io.c3
-rw-r--r--fs/btrfs/super.c4
-rw-r--r--fs/btrfs/volumes.c2
3 files changed, 4 insertions, 5 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 709e33d..5547607 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -728,9 +728,8 @@ struct btrfs_root *open_ctree(struct super_block *sb,
struct btrfs_root *dev_root = kmalloc(sizeof(struct btrfs_root),
GFP_NOFS);
int ret;
- int err = -EIO;
+ int err = -EINVAL;
struct btrfs_super_block *disk_super;
-
if (!extent_root || !tree_root || !fs_info) {
err = -ENOMEM;
goto fail;
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 9624923..8928649 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -236,9 +236,9 @@ static int btrfs_fill_super(struct super_block * sb,
tree_root = open_ctree(sb, fs_devices);
- if (!tree_root || IS_ERR(tree_root)) {
+ if (IS_ERR(tree_root)) {
printk("btrfs: open_ctree failed\n");
- return -EIO;
+ return PTR_ERR(tree_root);
}
sb->s_fs_info = tree_root;
disk_super = &tree_root->fs_info->super_copy;
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index d8fce32..169be0f 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -237,7 +237,7 @@ int btrfs_scan_one_device(const char *path, int flags, void *holder,
if (strncmp((char *)(&disk_super->magic), BTRFS_MAGIC,
sizeof(disk_super->magic))) {
printk("no btrfs found on %s\n", path);
- ret = -ENOENT;
+ ret = -EINVAL;
goto error_brelse;
}
devid = le64_to_cpu(disk_super->dev_item.devid);
OpenPOWER on IntegriCloud