summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorYann Droneaud <ydroneaud@opteya.com>2013-07-02 18:39:34 +0200
committerBen Myers <bpm@sgi.com>2013-07-09 15:53:57 -0500
commit862a62937e76a91da218c1ee4dceb7b0700fed67 (patch)
treeb8205ebf4bc54987f37c18e788a574b19ee4fc87 /fs
parent9cee4c5b7b706157554cb06ca949997240da725a (diff)
downloadop-kernel-dev-862a62937e76a91da218c1ee4dceb7b0700fed67.zip
op-kernel-dev-862a62937e76a91da218c1ee4dceb7b0700fed67.tar.gz
xfs: use get_unused_fd_flags(0) instead of get_unused_fd()
Macro get_unused_fd() is used to allocate a file descriptor with default flags. Those default flags (0) can be "unsafe": O_CLOEXEC must be used by default to not leak file descriptor across exec(). Instead of macro get_unused_fd(), functions anon_inode_getfd() or get_unused_fd_flags() should be used with flags given by userspace. If not possible, flags should be set to O_CLOEXEC to provide userspace with a default safe behavor. In a further patch, get_unused_fd() will be removed so that new code start using anon_inode_getfd() or get_unused_fd_flags() with correct flags. This patch replaces calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0) to preserve current behavor for existing code. The hard coded flag value (0) should be reviewed on a per-subsystem basis, and, if possible, set to O_CLOEXEC. Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> Reviewed-by: Ben Myers <bpm@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/xfs/xfs_ioctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 5e99968..dc5b659 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -248,7 +248,7 @@ xfs_open_by_handle(
goto out_dput;
}
- fd = get_unused_fd();
+ fd = get_unused_fd_flags(0);
if (fd < 0) {
error = fd;
goto out_dput;
OpenPOWER on IntegriCloud