summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorLi Zefan <lizf@cn.fujitsu.com>2009-04-08 15:07:30 +0800
committerAl Viro <viro@zeniv.linux.org.uk>2009-04-20 23:02:50 -0400
commit1c8542c7bb239ef02fe21477acd9cdac04c1b640 (patch)
tree45d9f29f241203608866f8246a699bc00b6ecf6b /fs
parentdae7b665cf6d6e6e733f1c9c16cf55547dd37e33 (diff)
downloadop-kernel-dev-1c8542c7bb239ef02fe21477acd9cdac04c1b640.zip
op-kernel-dev-1c8542c7bb239ef02fe21477acd9cdac04c1b640.tar.gz
sysfs: use memdup_user()
Remove open-coded memdup_user(). Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r--fs/sysfs/bin.c13
1 files changed, 3 insertions, 10 deletions
diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c
index 93e0c02..9345806 100644
--- a/fs/sysfs/bin.c
+++ b/fs/sysfs/bin.c
@@ -157,14 +157,9 @@ static ssize_t write(struct file *file, const char __user *userbuf,
count = size - offs;
}
- temp = kmalloc(count, GFP_KERNEL);
- if (!temp)
- return -ENOMEM;
-
- if (copy_from_user(temp, userbuf, count)) {
- count = -EFAULT;
- goto out_free;
- }
+ temp = memdup_user(userbuf, count);
+ if (IS_ERR(temp))
+ return PTR_ERR(temp);
mutex_lock(&bb->mutex);
@@ -176,8 +171,6 @@ static ssize_t write(struct file *file, const char __user *userbuf,
if (count > 0)
*off = offs + count;
-out_free:
- kfree(temp);
return count;
}
OpenPOWER on IntegriCloud