summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJulien Brunel <brunel@diku.dk>2008-09-24 16:22:22 -0500
committerEric Van Hensbergen <ericvh@ericvh-desktop.austin.ibm.com>2008-09-24 16:22:22 -0500
commit62aa528e0299ffef8e138d9d92d13e631d06c5ff (patch)
tree6dc9ca3bf077bf58352fe67e8adb4d4b304baba1 /fs
parent620678244bc7b83287e2e283ed4fe6b959e94b7d (diff)
downloadop-kernel-dev-62aa528e0299ffef8e138d9d92d13e631d06c5ff.zip
op-kernel-dev-62aa528e0299ffef8e138d9d92d13e631d06c5ff.tar.gz
9p: use an IS_ERR test rather than a NULL test
In case of error, the function p9_client_walk returns an ERR pointer, but never returns a NULL pointer. So a NULL test that comes after an IS_ERR test should be deleted. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @match_bad_null_test@ expression x, E; statement S1,S2; @@ x = p9_client_walk(...) ... when != x = E * if (x != NULL) S1 else S2 // </smpl> Signed-off-by: Julien Brunel <brunel@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/9p/vfs_inode.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index c95295c..e83aa5e 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -626,8 +626,7 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
return NULL;
error:
- if (fid)
- p9_client_clunk(fid);
+ p9_client_clunk(fid);
return ERR_PTR(result);
}
OpenPOWER on IntegriCloud