summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJan Blunck <jblunck@suse.de>2008-02-14 19:34:31 -0800
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2008-02-14 21:13:32 -0800
commit429731b1553bacf9a331c260c317a28aaa878edb (patch)
treed9feaea03f5abe2eb3ac6a40cbd4e4e3b4638e6a /fs
parentdb74ece990ea59a9ec9f00f8881026059ef5caf5 (diff)
downloadop-kernel-dev-429731b1553bacf9a331c260c317a28aaa878edb.zip
op-kernel-dev-429731b1553bacf9a331c260c317a28aaa878edb.tar.gz
Remove path_release_on_umount()
path_release_on_umount() should only be called from sys_umount(). I merged the function into sys_umount() instead of having in in namei.c. Signed-off-by: Jan Blunck <jblunck@suse.de> Acked-by: Christoph Hellwig <hch@lst.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/namei.c10
-rw-r--r--fs/namespace.c4
2 files changed, 3 insertions, 11 deletions
diff --git a/fs/namei.c b/fs/namei.c
index 5270398..3ed4d75 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -368,16 +368,6 @@ void path_release(struct nameidata *nd)
mntput(nd->mnt);
}
-/*
- * umount() mustn't call path_release()/mntput() as that would clear
- * mnt_expiry_mark
- */
-void path_release_on_umount(struct nameidata *nd)
-{
- dput(nd->dentry);
- mntput_no_expire(nd->mnt);
-}
-
/**
* release_open_intent - free up open intent resources
* @nd: pointer to nameidata
diff --git a/fs/namespace.c b/fs/namespace.c
index 63ced21..7937d30 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -690,7 +690,9 @@ asmlinkage long sys_umount(char __user * name, int flags)
retval = do_umount(nd.mnt, flags);
dput_and_out:
- path_release_on_umount(&nd);
+ /* we mustn't call path_put() as that would clear mnt_expiry_mark */
+ dput(nd.dentry);
+ mntput_no_expire(nd.mnt);
out:
return retval;
}
OpenPOWER on IntegriCloud