diff options
| author | Trond Myklebust <trond.myklebust@hammerspace.com> | 2018-07-20 16:19:35 -0400 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@hammerspace.com> | 2018-07-26 16:25:25 -0400 |
| commit | cf8340277f1128c4760976d0574359e6d765893c (patch) | |
| tree | b75c763b6e0da8197a441c2e3b543b5451198da3 /fs | |
| parent | 7be7b3ca16a59b8335ef2877f4696cf74f646d20 (diff) | |
| download | op-kernel-dev-cf8340277f1128c4760976d0574359e6d765893c.zip op-kernel-dev-cf8340277f1128c4760976d0574359e6d765893c.tar.gz | |
NFS: Fix excessive attribute revalidation in nfs_execute_ok()
When nfs_update_inode() sets NFS_INO_INVALID_ACCESS it is a sign that
we want to revalidate the access cache, not the inode attributes.
In fact we only want to revalidate here if we see that the mode bits
are invalid, so check for NFS_INO_INVALID_OTHER instead.
Reported-by: Olga Kornievskaia <aglo@umich.edu>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/dir.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 8f8e9e9..e7bc68f 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -2500,7 +2500,7 @@ static int nfs_execute_ok(struct inode *inode, int mask) struct nfs_server *server = NFS_SERVER(inode); int ret = 0; - if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_ACCESS)) { + if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_OTHER)) { if (mask & MAY_NOT_BLOCK) return -ECHILD; ret = __nfs_revalidate_inode(server, inode); |
