summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorAndy Lutomirski <luto@amacapital.net>2013-08-01 21:07:52 -0700
committerAl Viro <viro@zeniv.linux.org.uk>2013-08-05 18:24:10 +0400
commite305f48bc453da773a3601135a2cce40b8e62856 (patch)
tree8352de3ce7907543f435875464d86712b602dfc2 /fs
parent672fe15d091ce76d6fb98e489962e9add7c1ba4c (diff)
downloadop-kernel-dev-e305f48bc453da773a3601135a2cce40b8e62856.zip
op-kernel-dev-e305f48bc453da773a3601135a2cce40b8e62856.tar.gz
fs: Fix file mode for O_TMPFILE
O_TMPFILE, like O_CREAT, should respect the requested mode and should create regular files. This fixes two bugs: O_TMPFILE required privilege (because the mode ended up as 000) and it produced bogus inodes with no type. Signed-off-by: Andy Lutomirski <luto@amacapital.net> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r--fs/open.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/open.c b/fs/open.c
index d53e298..7931f76 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -823,7 +823,7 @@ static inline int build_open_flags(int flags, umode_t mode, struct open_flags *o
int lookup_flags = 0;
int acc_mode;
- if (flags & O_CREAT)
+ if (flags & (O_CREAT | __O_TMPFILE))
op->mode = (mode & S_IALLUGO) | S_IFREG;
else
op->mode = 0;
OpenPOWER on IntegriCloud