summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2013-05-07 11:28:31 -0400
committerSteve French <smfrench@gmail.com>2013-05-08 17:12:47 -0500
commitc2b93e0699723700f886ce17bb65ffd771195a6d (patch)
tree174d082487c61ca59e166c5f0b906595f6facc5a /fs
parentebb37277796269da36a8bc5d72ed1e8e1fb7d34b (diff)
downloadop-kernel-dev-c2b93e0699723700f886ce17bb65ffd771195a6d.zip
op-kernel-dev-c2b93e0699723700f886ce17bb65ffd771195a6d.tar.gz
cifs: only set ops for inodes in I_NEW state
It's generally not safe to reset the inode ops once they've been set. In the case where the inode was originally thought to be a directory and then later found to be a DFS referral, this can lead to an oops when we try to trigger an inode op on it after changing the ops to the blank referral operations. Cc: <stable@vger.kernel.org> Reported-and-Tested-by: Sachin Prabhu <sprabhu@redhat.com> Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/cifs/inode.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index fc30251..20efd81 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -171,7 +171,8 @@ cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr)
if (fattr->cf_flags & CIFS_FATTR_DFS_REFERRAL)
inode->i_flags |= S_AUTOMOUNT;
- cifs_set_ops(inode);
+ if (inode->i_state & I_NEW)
+ cifs_set_ops(inode);
}
void
OpenPOWER on IntegriCloud