summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2014-01-07 13:08:03 -0500
committerTheodore Ts'o <tytso@mit.edu>2014-01-07 13:08:03 -0500
commit8c9367fd9bf252b57c6d4f8e1a7f9de809d8b862 (patch)
treeca8fe69ef574fa50909b7fd5e993b47bdb10c3da /fs
parent09c455aaa8f47a94d5bafaa23d58365768210507 (diff)
downloadop-kernel-dev-8c9367fd9bf252b57c6d4f8e1a7f9de809d8b862.zip
op-kernel-dev-8c9367fd9bf252b57c6d4f8e1a7f9de809d8b862.tar.gz
ext4: don't pass freed handle to ext4_walk_page_buffers
This is harmless, since ext4_walk_page_buffers only passes the handle onto the callback function, and in this call site the function in question, bput_one(), doesn't actually use the handle. But there's no point passing in an invalid handle, and it creates a Coverity warning, so let's just clean it up. Addresses-Coverity-Id: #1091168 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext4/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 8454ebe2..f33b4eb 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -1772,7 +1772,7 @@ static int __ext4_journalled_writepage(struct page *page,
ret = err;
if (!ext4_has_inline_data(inode))
- ext4_walk_page_buffers(handle, page_bufs, 0, len,
+ ext4_walk_page_buffers(NULL, page_bufs, 0, len,
NULL, bput_one);
ext4_set_inode_state(inode, EXT4_STATE_JDATA);
out:
OpenPOWER on IntegriCloud