summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorMaxim <maxim.patlasov@gmail.com>2011-03-14 13:19:21 +0000
committerSteven Whitehouse <swhiteho@redhat.com>2011-03-14 13:19:21 +0000
commit6c474f7bc1ef70bc05ce486e7e7e524124122de8 (patch)
treec052a112e8719fdc8e72cf857be3ceaf183a6ac5 /fs
parentc618e87a5fd02aaad006c12d5a80a231dfa39250 (diff)
downloadop-kernel-dev-6c474f7bc1ef70bc05ce486e7e7e524124122de8.zip
op-kernel-dev-6c474f7bc1ef70bc05ce486e7e7e524124122de8.tar.gz
GFS2: Adding missing unlock_page()
gfs2_write_begin() calls grab_cache_page_write_begin() that returns *locked* page. Correspondent error-handling path lacks for unlock_page() call: > out: > if (error == 0) > return 0; > > page_cache_release(page); The whole system hangs if gfs2_unstuff_dinode() called from gfs2_write_begin() failed for some reason. Reported-by: Maxim <maxim.patlasov@gmail.com> Signed-off-by: Maxim <maxim.patlasov@gmail.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/gfs2/aops.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 4f36f88..aad77e4 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -695,6 +695,7 @@ out:
if (error == 0)
return 0;
+ unlock_page(page);
page_cache_release(page);
gfs2_trans_end(sdp);
OpenPOWER on IntegriCloud