diff options
| author | Dan Rosenberg <dan.j.rosenberg@gmail.com> | 2010-05-15 11:27:37 -0400 |
|---|---|---|
| committer | Chris Mason <chris.mason@oracle.com> | 2010-05-15 12:05:50 -0400 |
| commit | 5dc6416414fb3ec6e2825fd4d20c8bf1d7fe0395 (patch) | |
| tree | e15101a2d1302ff6f2830f282197b34060ec963c /fs | |
| parent | 9f680ce04ea19dabbbafe01b57b61930a9b70741 (diff) | |
| download | op-kernel-dev-5dc6416414fb3ec6e2825fd4d20c8bf1d7fe0395.zip op-kernel-dev-5dc6416414fb3ec6e2825fd4d20c8bf1d7fe0395.tar.gz | |
Btrfs: check for read permission on src file in the clone ioctl
The existing code would have allowed you to clone a file that was
only open for writing
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/ioctl.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 2b7dd88..9de6c3a 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1480,12 +1480,17 @@ static noinline long btrfs_ioctl_clone(struct file *file, unsigned long srcfd, ret = -EBADF; goto out_drop_write; } + src = src_file->f_dentry->d_inode; ret = -EINVAL; if (src == inode) goto out_fput; + /* the src must be open for reading */ + if (!(src_file->f_mode & FMODE_READ)) + goto out_fput; + ret = -EISDIR; if (S_ISDIR(src->i_mode) || S_ISDIR(inode->i_mode)) goto out_fput; |
