summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorLiu Bo <bo.li.liu@oracle.com>2014-08-19 23:33:13 +0800
committerChris Mason <clm@fb.com>2014-08-21 07:55:30 -0700
commit38c1c2e44bacb37efd68b90b3f70386a8ee370ee (patch)
treebbd9745859fd71b54b0d07707554f973a3f00d40 /fs
parenta3c108950d8e0bfcf48856cc159956022a7ad925 (diff)
downloadop-kernel-dev-38c1c2e44bacb37efd68b90b3f70386a8ee370ee.zip
op-kernel-dev-38c1c2e44bacb37efd68b90b3f70386a8ee370ee.tar.gz
Btrfs: fix crash on endio of reading corrupted block
The crash is ------------[ cut here ]------------ kernel BUG at fs/btrfs/extent_io.c:2124! [...] Workqueue: btrfs-endio normal_work_helper [btrfs] RIP: 0010:[<ffffffffa02d6055>] [<ffffffffa02d6055>] end_bio_extent_readpage+0xb45/0xcd0 [btrfs] This is in fact a regression. It is because we forgot to increase @offset properly in reading corrupted block, so that the @offset remains, and this leads to checksum errors while reading left blocks queued up in the same bio, and then ends up with hiting the above BUG_ON. Reported-by: Chris Murphy <lists@colorremedies.com> Signed-off-by: Liu Bo <bo.li.liu@oracle.com> Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/btrfs/extent_io.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 1c70cff..f34b1e2 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2532,6 +2532,7 @@ static void end_bio_extent_readpage(struct bio *bio, int err)
test_bit(BIO_UPTODATE, &bio->bi_flags);
if (err)
uptodate = 0;
+ offset += len;
continue;
}
}
OpenPOWER on IntegriCloud