diff options
| author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-07-07 13:26:10 -0400 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-07-08 15:22:40 -0400 |
| commit | 2aac05a91971fbd1bf6cbed78b8731eb7454b9b7 (patch) | |
| tree | 1bbbb13b7e4353bc729363582eef95925c523b7b /fs | |
| parent | 9c0fc4e28b57c5a6da7b58d60f71476c64d457a6 (diff) | |
| download | op-kernel-dev-2aac05a91971fbd1bf6cbed78b8731eb7454b9b7.zip op-kernel-dev-2aac05a91971fbd1bf6cbed78b8731eb7454b9b7.tar.gz | |
NFS: Fix readdir cache invalidation
invalidate_inode_pages2_range() takes page offset arguments, not byte
ranges.
Another thought is that individual pages might perhaps get evicted by VM
pressure, in which case we might perhaps want to re-read not only the
evicted page, but all subsequent pages too (in case the server returns
more/less data per page so that the alignment of the next entry
changes). We should therefore remove the condition that we only do this on
page->index==0.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/dir.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 58d43da..982a206 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -204,7 +204,7 @@ int nfs_readdir_filler(nfs_readdir_descriptor_t *desc, struct page *page) * Note: assumes we have exclusive access to this mapping either * through inode->i_mutex or some other mechanism. */ - if (page->index == 0 && invalidate_inode_pages2_range(inode->i_mapping, PAGE_CACHE_SIZE, -1) < 0) { + if (invalidate_inode_pages2_range(inode->i_mapping, page->index + 1, -1) < 0) { /* Should never happen */ nfs_zap_mapping(inode, inode->i_mapping); } |
