summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorMiklos Szeredi <mszeredi@suse.cz>2008-05-21 19:15:03 +0200
committerAl Viro <viro@zeniv.linux.org.uk>2008-07-26 20:53:13 -0400
commit1bd5191d9f5d1928c4efdf604c4164b04bb88dbe (patch)
treea0395f9e5a05c093ee3f5f1d816b2a053bad1f5c /fs
parent9043476f726802f4b00c96d0c4f418dde48d1304 (diff)
downloadop-kernel-dev-1bd5191d9f5d1928c4efdf604c4164b04bb88dbe.zip
op-kernel-dev-1bd5191d9f5d1928c4efdf604c4164b04bb88dbe.tar.gz
[patch 05/14] hpfs: dont call permission()
hpfs_unlink() calls permission() prior to truncating the file. HPFS doesn't define a .permission method, so replace with explicit call to generic_permission(). This is equivalent, except that devcgroup_inode_permission() and security_inode_permission() are not called. The truncation is just an implementation detail of the unlink, so these security checks are unnecessary. I suspect that even calling generic_permission() is unnecessary, since we shouldn't mind if the file isn't writable. But I leave that to the maintainer to decide. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> CC: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Diffstat (limited to 'fs')
-rw-r--r--fs/hpfs/namei.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c
index d256559..d9c59a7 100644
--- a/fs/hpfs/namei.c
+++ b/fs/hpfs/namei.c
@@ -415,7 +415,7 @@ again:
d_drop(dentry);
spin_lock(&dentry->d_lock);
if (atomic_read(&dentry->d_count) > 1 ||
- permission(inode, MAY_WRITE, NULL) ||
+ generic_permission(inode, MAY_WRITE, NULL) ||
!S_ISREG(inode->i_mode) ||
get_write_access(inode)) {
spin_unlock(&dentry->d_lock);
OpenPOWER on IntegriCloud