summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorSteven Whitehouse <swhiteho@redhat.com>2010-02-12 10:10:55 +0000
committerSteven Whitehouse <swhiteho@redhat.com>2010-02-12 10:16:14 +0000
commit07ccb7bf2c928fef4fea2cda69ba2e23479578db (patch)
tree6aee126126d3a1245b5b9f79abe2101098392187 /fs
parent0e5a9fb0426108d750c97c25b1ab04d3768b5aff (diff)
downloadop-kernel-dev-07ccb7bf2c928fef4fea2cda69ba2e23479578db.zip
op-kernel-dev-07ccb7bf2c928fef4fea2cda69ba2e23479578db.tar.gz
GFS2: Fix bmap allocation corner-case bug
This patch solves a corner case during allocation which occurs if both metadata (indirect) and data blocks are required but there is an obstacle in the filesystem (e.g. a resource group header or another allocated block) such that when the allocation is requested only enough blocks for the metadata are returned. By changing the exit condition of this loop, we ensure that a minimum of one data block will always be returned. Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/gfs2/bmap.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index 6d47379..583e823 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -541,7 +541,7 @@ static int gfs2_bmap_alloc(struct inode *inode, const sector_t lblock,
*ptr++ = cpu_to_be64(bn++);
break;
}
- } while (state != ALLOC_DATA);
+ } while ((state != ALLOC_DATA) || !dblock);
ip->i_height = height;
gfs2_add_inode_blocks(&ip->i_inode, alloced);
OpenPOWER on IntegriCloud