summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-04-22 11:39:29 +0200
committerJoel Becker <joel.becker@oracle.com>2010-04-23 14:42:06 -0700
commit0350cb078f5035716ebdad4ad4709d02fe466a8a (patch)
tree17b2166b5c71e22571b0c244e130325d33bb77aa /fs
parent79681842e160c3211eeeb47ea31b061038d1e41e (diff)
downloadop-kernel-dev-0350cb078f5035716ebdad4ad4709d02fe466a8a.zip
op-kernel-dev-0350cb078f5035716ebdad4ad4709d02fe466a8a.tar.gz
ocfs2: potential ERR_PTR dereference on error paths
If "handle" is non null at the end of the function then we assume it's a valid pointer and pass it to ocfs2_commit_trans(); Signed-off-by: Dan Carpenter <error27@gmail.com> Cc: <stable@kernel.org> Signed-off-by: Joel Becker <joel.becker@oracle.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/ocfs2/inode.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index ab20790..23c254e 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -559,6 +559,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb,
handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
if (IS_ERR(handle)) {
status = PTR_ERR(handle);
+ handle = NULL;
mlog_errno(status);
goto out;
}
OpenPOWER on IntegriCloud