summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2016-01-14 13:41:14 +0300
committerSteve French <sfrench@localhost.localdomain>2016-01-14 14:45:49 -0600
commit01b9b0b28626db4a47d7f48744d70abca9914ef1 (patch)
treefd31f5cc68e6b880be1315249de944ad8ffcd023 /fs
parent820962dc700598ffe8cd21b967e30e7520c34748 (diff)
downloadop-kernel-dev-01b9b0b28626db4a47d7f48744d70abca9914ef1.zip
op-kernel-dev-01b9b0b28626db4a47d7f48744d70abca9914ef1.tar.gz
cifs_dbg() outputs an uninitialized buffer in cifs_readdir()
In some cases tmp_bug can be not filled in cifs_filldir and stay uninitialized, therefore its printk with "%s" modifier can leak content of kernelspace memory. If old content of this buffer does not contain '\0' access bejond end of allocated object can crash the host. Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Steve French <sfrench@localhost.localdomain> CC: Stable <stable@vger.kernel.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/cifs/readdir.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
index 0557c45..b30a4a6 100644
--- a/fs/cifs/readdir.c
+++ b/fs/cifs/readdir.c
@@ -847,6 +847,7 @@ int cifs_readdir(struct file *file, struct dir_context *ctx)
* if buggy server returns . and .. late do we want to
* check for that here?
*/
+ *tmp_buf = 0;
rc = cifs_filldir(current_entry, file, ctx,
tmp_buf, max_len);
if (rc) {
OpenPOWER on IntegriCloud