diff options
| author | Julia Lawall <julia@diku.dk> | 2010-02-06 08:45:15 +0000 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2010-02-13 13:22:53 -0600 |
| commit | d67b1b03254c501fef371b0e5916c94a52bfc2c5 (patch) | |
| tree | 87d3505cb841844055c113fd9eea124ed31e2ba0 /fs/xfs | |
| parent | 180040b89ee2aed88c0a0b1fcf7ada9a512b12e3 (diff) | |
| download | op-kernel-dev-d67b1b03254c501fef371b0e5916c94a52bfc2c5.zip op-kernel-dev-d67b1b03254c501fef371b0e5916c94a52bfc2c5.tar.gz | |
fs/xfs: Correct NULL test
Test the value that was just allocated rather than the previously tested one.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@
if (x == NULL || ...) {
... when forall
return ...; }
... when != goto l;
when != x = e
when != &x
*x == NULL
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/quota/xfs_qm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c index 8699e51..417e61e 100644 --- a/fs/xfs/quota/xfs_qm.c +++ b/fs/xfs/quota/xfs_qm.c @@ -123,7 +123,7 @@ xfs_Gqm_init(void) goto out; gdqhash = kmem_zalloc_large(hsize); - if (!udqhash) + if (!gdqhash) goto out_free_udqhash; hsize /= sizeof(xfs_dqhash_t); |
