diff options
| author | Dave Chinner <dchinner@redhat.com> | 2011-01-27 13:23:28 +1100 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2011-01-28 09:05:36 -0600 |
| commit | c6f990d1ff8e4e53b12f4175eb7d7ea710c3ca73 (patch) | |
| tree | 109e8d588a9a04ef52b97e751450fe0fffa88a23 /fs/xfs/xfs_trans.c | |
| parent | 5315837daee7ed76c31ef643915f7d76ef8c1aa3 (diff) | |
| download | op-kernel-dev-c6f990d1ff8e4e53b12f4175eb7d7ea710c3ca73.zip op-kernel-dev-c6f990d1ff8e4e53b12f4175eb7d7ea710c3ca73.tar.gz | |
xfs: handle CIl transaction commit failures correctly
Failure to commit a transaction into the CIL is not handled
correctly. This currently can only happen when racing with a
shutdown and requires an explicit shutdown check, so it rare and can
be avoided. Remove the shutdown check and make the CIL commit a void
function to indicate it will always succeed, thereby removing the
incorrectly handled failure case.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_trans.c')
| -rw-r--r-- | fs/xfs/xfs_trans.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index 29f5e54..7692279 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c @@ -1755,7 +1755,6 @@ xfs_trans_commit_cil( int flags) { struct xfs_log_vec *log_vector; - int error; /* * Get each log item to allocate a vector structure for @@ -1766,9 +1765,7 @@ xfs_trans_commit_cil( if (!log_vector) return ENOMEM; - error = xfs_log_commit_cil(mp, tp, log_vector, commit_lsn, flags); - if (error) - return error; + xfs_log_commit_cil(mp, tp, log_vector, commit_lsn, flags); current_restore_flags_nested(&tp->t_pflags, PF_FSTRANS); xfs_trans_free(tp); |
