diff options
| author | Dave Chinner <dchinner@redhat.com> | 2013-08-27 11:39:37 +1000 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2013-08-30 13:45:49 -0500 |
| commit | d8914002a0391331a88d9f5de4a235220735d4cc (patch) | |
| tree | 4fbdcc1bae11941554c98651985878cf1e47ad36 /fs/xfs/xfs_log_recover.c | |
| parent | 50d5c8d8e938e3c4c0d21db9fc7d64282dc7be20 (diff) | |
| download | op-kernel-dev-d8914002a0391331a88d9f5de4a235220735d4cc.zip op-kernel-dev-d8914002a0391331a88d9f5de4a235220735d4cc.tar.gz | |
xfs: inode buffers may not be valid during recovery readahead
CRC enabled filesystems fail log recovery with 100% reliability on
xfstests xfs/085 with the following failure:
XFS (vdb): Mounting Filesystem
XFS (vdb): Starting recovery (logdev: internal)
XFS (vdb): Corruption detected. Unmount and run xfs_repair
XFS (vdb): bad inode magic/vsn daddr 144 #0 (magic=0)
XFS: Assertion failed: 0, file: fs/xfs/xfs_inode_buf.c, line: 95
The problem is that the inode buffer has not been recovered before
the readahead on the inode buffer is issued. The checkpoint being
recovered actually allocates the inode chunk we are doing readahead
from, so what comes from disk during readahead is essentially
random and the verifier barfs on it.
This inode buffer readahead problem affects non-crc filesystems,
too, but xfstests does not trigger it at all on such
configurations....
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_log_recover.c')
| -rw-r--r-- | fs/xfs/xfs_log_recover.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index dc100fe..7c0c1fd 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -3309,7 +3309,7 @@ xlog_recover_inode_ra_pass2( return; xfs_buf_readahead(mp->m_ddev_targp, ilfp->ilf_blkno, - ilfp->ilf_len, &xfs_inode_buf_ops); + ilfp->ilf_len, &xfs_inode_buf_ra_ops); } STATIC void |
