diff options
| author | David Chinner <dgc@sgi.com> | 2008-04-10 12:20:24 +1000 |
|---|---|---|
| committer | Lachlan McIlroy <lachlan@redback.melbourne.sgi.com> | 2008-04-18 11:56:55 +1000 |
| commit | 3c56836f92683cb871ebbf44c512069b0d48a08f (patch) | |
| tree | ac0ef5d76e086aa6e2542fb5548db26af5967297 /fs/xfs/quota/xfs_dquot_item.c | |
| parent | 4b8879df8c21bed3efd1eb2da5d72501199aba29 (diff) | |
| download | op-kernel-dev-3c56836f92683cb871ebbf44c512069b0d48a08f.zip op-kernel-dev-3c56836f92683cb871ebbf44c512069b0d48a08f.tar.gz | |
[XFS] Check for dquot flush errors
xfs_qm_dqflush() can fail, but the return is not checked anywhere. Hence
we never know if we've failed to flush a dquot to disk. Propagate the
error and warn to the syslog if a flush ever fails.
SGI-PV: 980084
SGI-Modid: xfs-linux-melb:xfs-kern:30787a
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Diffstat (limited to 'fs/xfs/quota/xfs_dquot_item.c')
| -rw-r--r-- | fs/xfs/quota/xfs_dquot_item.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/xfs/quota/xfs_dquot_item.c b/fs/xfs/quota/xfs_dquot_item.c index 1800e8d..3dedce1 100644 --- a/fs/xfs/quota/xfs_dquot_item.c +++ b/fs/xfs/quota/xfs_dquot_item.c @@ -146,6 +146,7 @@ xfs_qm_dquot_logitem_push( xfs_dq_logitem_t *logitem) { xfs_dquot_t *dqp; + int error; dqp = logitem->qli_dquot; @@ -161,7 +162,11 @@ xfs_qm_dquot_logitem_push( * lock without sleeping, then there must not have been * anyone in the process of flushing the dquot. */ - xfs_qm_dqflush(dqp, XFS_B_DELWRI); + error = xfs_qm_dqflush(dqp, XFS_QMOPT_DELWRI); + if (error) + xfs_fs_cmn_err(CE_WARN, dqp->q_mount, + "xfs_qm_dquot_logitem_push: push error %d on dqp %p", + error, dqp); xfs_dqunlock(dqp); } |
