summaryrefslogtreecommitdiffstats
path: root/fs/udf
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2015-01-07 13:49:08 +0100
committerJan Kara <jack@suse.cz>2015-01-07 13:51:58 +0100
commit23b133bdc452aa441fcb9b82cbf6dd05cfd342d0 (patch)
tree366f6b425458f89548800ccd2f2f774df63e705d /fs/udf
parent79144954278d4bb5989f8b903adcac7a20ff2a5a (diff)
downloadop-kernel-dev-23b133bdc452aa441fcb9b82cbf6dd05cfd342d0.zip
op-kernel-dev-23b133bdc452aa441fcb9b82cbf6dd05cfd342d0.tar.gz
udf: Check length of extended attributes and allocation descriptors
Check length of extended attributes and allocation descriptors when loading inodes from disk. Otherwise corrupted filesystems could confuse the code and make the kernel oops. Reported-by: Carl Henrik Lunde <chlunde@ping.uio.no> CC: stable@vger.kernel.org Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf')
-rw-r--r--fs/udf/inode.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 95cb697..7b72b7d 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -1487,6 +1487,15 @@ reread:
}
inode->i_generation = iinfo->i_unique;
+ /*
+ * Sanity check length of allocation descriptors and extended attrs to
+ * avoid integer overflows
+ */
+ if (iinfo->i_lenEAttr > bs || iinfo->i_lenAlloc > bs)
+ goto out;
+ /* Now do exact checks */
+ if (udf_file_entry_alloc_offset(inode) + iinfo->i_lenAlloc > bs)
+ goto out;
/* Sanity checks for files in ICB so that we don't get confused later */
if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) {
/*
OpenPOWER on IntegriCloud