summaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorChao Yu <chao2.yu@samsung.com>2015-05-18 16:43:02 +0800
committerRichard Weinberger <richard@nod.at>2015-06-02 11:41:38 +0200
commita1fe33af5f8c5f5aebe68d22125d19e48b8e601c (patch)
treed86bdb38a53af379bf76888f779214deb6d9edb0 /fs/ubifs
parent2bf50d42f3a418153d2964ca0f25655177f36445 (diff)
downloadop-kernel-dev-a1fe33af5f8c5f5aebe68d22125d19e48b8e601c.zip
op-kernel-dev-a1fe33af5f8c5f5aebe68d22125d19e48b8e601c.tar.gz
ubifs: fix to check error code of register_shrinker
register_shrinker() in ubifs_init() can fail due to fail to call kzalloc. This patch fixes to check the return value of register_shrinker, otherwise our shrinker may be unregistered after ubifs initialized successfully. Signed-off-by: Chao Yu <chao2.yu@samsung.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/super.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 75e6f04..fa83d1b 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2245,7 +2245,9 @@ static int __init ubifs_init(void)
if (!ubifs_inode_slab)
return -ENOMEM;
- register_shrinker(&ubifs_shrinker_info);
+ err = register_shrinker(&ubifs_shrinker_info);
+ if (err)
+ goto out_slab;
err = ubifs_compressors_init();
if (err)
@@ -2269,6 +2271,7 @@ out_compr:
ubifs_compressors_exit();
out_shrinker:
unregister_shrinker(&ubifs_shrinker_info);
+out_slab:
kmem_cache_destroy(ubifs_inode_slab);
return err;
}
OpenPOWER on IntegriCloud