diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-09-27 01:49:40 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 08:26:10 -0700 |
| commit | 1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b (patch) | |
| tree | fade83955f75e718e39153d6f81d221403338bed /fs/smbfs | |
| parent | f52720ca5f48574e347dff35ffe6b389ace61537 (diff) | |
| download | op-kernel-dev-1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b.zip op-kernel-dev-1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b.tar.gz | |
[PATCH] Really ignore kmem_cache_destroy return value
* Rougly half of callers already do it by not checking return value
* Code in drivers/acpi/osl.c does the following to be sure:
(void)kmem_cache_destroy(cache);
* Those who check it printk something, however, slab_error already printed
the name of failed cache.
* XFS BUGs on failed kmem_cache_destroy which is not the decision
low-level filesystem driver should make. Converted to ignore.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/smbfs')
| -rw-r--r-- | fs/smbfs/inode.c | 3 | ||||
| -rw-r--r-- | fs/smbfs/request.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/fs/smbfs/inode.c b/fs/smbfs/inode.c index a1ed657..92cf60a 100644 --- a/fs/smbfs/inode.c +++ b/fs/smbfs/inode.c @@ -89,8 +89,7 @@ static int init_inodecache(void) static void destroy_inodecache(void) { - if (kmem_cache_destroy(smb_inode_cachep)) - printk(KERN_INFO "smb_inode_cache: not all structures were freed\n"); + kmem_cache_destroy(smb_inode_cachep); } static int smb_remount(struct super_block *sb, int *flags, char *data) diff --git a/fs/smbfs/request.c b/fs/smbfs/request.c index c8e9619..0fb7469 100644 --- a/fs/smbfs/request.c +++ b/fs/smbfs/request.c @@ -49,8 +49,7 @@ int smb_init_request_cache(void) void smb_destroy_request_cache(void) { - if (kmem_cache_destroy(req_cachep)) - printk(KERN_INFO "smb_destroy_request_cache: not all structures were freed\n"); + kmem_cache_destroy(req_cachep); } /* |
