summaryrefslogtreecommitdiffstats
path: root/fs/pipe.c
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2008-04-22 19:51:27 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2008-04-22 19:54:57 -0400
commited1524371716466e9c762808b02601d0d0276a92 (patch)
tree73a9f836f54164f70649a318fe775638c79417b8 /fs/pipe.c
parent521b5d0c40386f4a9805cdec7bd979fc96a86aeb (diff)
downloadop-kernel-dev-ed1524371716466e9c762808b02601d0d0276a92.zip
op-kernel-dev-ed1524371716466e9c762808b02601d0d0276a92.tar.gz
[PATCH] double-free of inode on alloc_file() failure exit in create_write_pipe()
Duh... Fortunately, the bug is quite recent (post-2.6.25) and, embarrassingly, mine ;-/ Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/pipe.c')
-rw-r--r--fs/pipe.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/pipe.c b/fs/pipe.c
index 8be381b..f73492b 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -988,7 +988,10 @@ struct file *create_write_pipe(void)
return f;
err_dentry:
+ free_pipe_info(inode);
dput(dentry);
+ return ERR_PTR(err);
+
err_inode:
free_pipe_info(inode);
iput(inode);
OpenPOWER on IntegriCloud