diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2016-06-04 11:02:33 +0200 |
|---|---|---|
| committer | Mike Marshall <hubcap@omnibond.com> | 2016-07-05 15:47:27 -0400 |
| commit | d373a712c1142a4e119e359df63c192afa9bb2fb (patch) | |
| tree | b313d3fea4ed4b5adb71afa044cdf1341f4ff1bc /fs/orangefs/acl.c | |
| parent | 2ce8272a1014d9d0d2f859ffba9a815f9ce12f99 (diff) | |
| download | op-kernel-dev-d373a712c1142a4e119e359df63c192afa9bb2fb.zip op-kernel-dev-d373a712c1142a4e119e359df63c192afa9bb2fb.tar.gz | |
orangefs: Remove useless xattr prefix arguments
Mike,
On Fri, Jun 3, 2016 at 9:44 PM, Mike Marshall <hubcap@omnibond.com> wrote:
> We use the return value in this one line you changed, our userspace code gets
> ill when we send it (-ENOMEM +1) as a key length...
ah, my mistake. Here's a fixed version.
Thanks,
Andreas
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Diffstat (limited to 'fs/orangefs/acl.c')
| -rw-r--r-- | fs/orangefs/acl.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c index df24864..28f2195 100644 --- a/fs/orangefs/acl.c +++ b/fs/orangefs/acl.c @@ -43,11 +43,8 @@ struct posix_acl *orangefs_get_acl(struct inode *inode, int type) get_khandle_from_ino(inode), key, type); - ret = orangefs_inode_getxattr(inode, - "", - key, - value, - ORANGEFS_MAX_XATTR_VALUELEN); + ret = orangefs_inode_getxattr(inode, key, value, + ORANGEFS_MAX_XATTR_VALUELEN); /* if the key exists, convert it to an in-memory rep */ if (ret > 0) { acl = posix_acl_from_xattr(&init_user_ns, value, ret); @@ -131,7 +128,7 @@ int orangefs_set_acl(struct inode *inode, struct posix_acl *acl, int type) * will xlate to a removexattr. However, we don't want removexattr * complain if attributes does not exist. */ - error = orangefs_inode_setxattr(inode, "", name, value, size, 0); + error = orangefs_inode_setxattr(inode, name, value, size, 0); out: kfree(value); |
