diff options
| author | Milton Miller <miltonm@bga.com> | 2010-11-17 22:20:11 -0600 |
|---|---|---|
| committer | Joel Becker <joel.becker@oracle.com> | 2010-11-18 14:10:56 -0800 |
| commit | a2a2f55291918f6cf9287d7beaecc7bc007a9f1c (patch) | |
| tree | 8fd82a27d2a90e302edcb0ce443b12913615cab2 /fs/ocfs2 | |
| parent | 1989a80a60d2f620bad99196d6c1801c2afd7c71 (diff) | |
| download | op-kernel-dev-a2a2f55291918f6cf9287d7beaecc7bc007a9f1c.zip op-kernel-dev-a2a2f55291918f6cf9287d7beaecc7bc007a9f1c.tar.gz | |
ocfs2: char is not always signed
Commit 1c66b360fe262 (Change some lock status member in ocfs2_lock_res
to char.) states that these fields need to be signed due to comparision
to -1, but only changed the type from unsigned char to char. However, it
is a compiler option if char is a signed or unsigned type. Change these
fields to signed char so the code will work with all compilers.
Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Diffstat (limited to 'fs/ocfs2')
| -rw-r--r-- | fs/ocfs2/ocfs2.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/ocfs2/ocfs2.h b/fs/ocfs2/ocfs2.h index 1efea36..70dd3b1 100644 --- a/fs/ocfs2/ocfs2.h +++ b/fs/ocfs2/ocfs2.h @@ -159,9 +159,9 @@ struct ocfs2_lock_res { char l_name[OCFS2_LOCK_ID_MAX_LEN]; unsigned int l_ro_holders; unsigned int l_ex_holders; - char l_level; - char l_requested; - char l_blocking; + signed char l_level; + signed char l_requested; + signed char l_blocking; /* Data packed - type enum ocfs2_lock_type */ unsigned char l_type; |
