diff options
author | Julia Lawall <julia@diku.dk> | 2008-07-21 09:59:15 +0200 |
---|---|---|
committer | Mark Fasheh <mfasheh@suse.com> | 2008-07-31 16:21:14 -0700 |
commit | c259ae52e204d42f8b2d484c85517a4c367030e1 (patch) | |
tree | e5f9e57aeee77704758c6dfeb19654140a827ef2 /fs/ocfs2/file.c | |
parent | 961cecbee6786f4b1f1b8f695e87045b583f9f49 (diff) | |
download | op-kernel-dev-c259ae52e204d42f8b2d484c85517a4c367030e1.zip op-kernel-dev-c259ae52e204d42f8b2d484c85517a4c367030e1.tar.gz |
[PATCH] ocfs2: Release mutex in error handling code
The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.
The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression l;
@@
mutex_lock(l);
... when != mutex_unlock(l)
when any
when strict
(
if (...) { ... when != mutex_unlock(l)
+ mutex_unlock(l);
return ...;
}
|
mutex_unlock(l);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Diffstat (limited to 'fs/ocfs2/file.c')
-rw-r--r-- | fs/ocfs2/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index be2dd95..ec2ed15 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -1766,8 +1766,8 @@ out_inode_unlock: out_rw_unlock: ocfs2_rw_unlock(inode, 1); - mutex_unlock(&inode->i_mutex); out: + mutex_unlock(&inode->i_mutex); return ret; } |