diff options
| author | Eric Paris <eparis@redhat.com> | 2009-07-13 15:56:55 -0400 |
|---|---|---|
| committer | Eric Paris <eparis@redhat.com> | 2009-07-21 15:26:26 -0400 |
| commit | 4a148ba988988b9c400ad0f2cbccc155289b954b (patch) | |
| tree | e80e3cd0d182721038b1d83a55cbde828c98cb09 /fs/notify | |
| parent | 520dc2a526fd681337883b6ff1ddcf7c23b1b063 (diff) | |
| download | op-kernel-dev-4a148ba988988b9c400ad0f2cbccc155289b954b.zip op-kernel-dev-4a148ba988988b9c400ad0f2cbccc155289b954b.tar.gz | |
inotify: check filename before dropping repeat events
inotify drops events if the last event on the queue is the same as the
current event. But it does 2 things wrong. First it is comparing old->inode
with new->inode. But after an event if put on the queue the ->inode is no
longer allowed to be used. It's possible between the last event and this new
event the inode could be reused and we would falsely match the inode's memory
address between two differing events.
The second problem is that when a file is removed fsnotify is passed the
negative dentry for the removed object rather than the postive dentry from
immediately before the removal. This mean the (broken) inotify tail drop code
was matching the NULL ->inode of differing events.
The fix is to check the file name which is stored with events when doing the
tail drop instead of wrongly checking the address of the stored ->inode.
Reported-by: Scott James Remnant <scott@ubuntu.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'fs/notify')
| -rw-r--r-- | fs/notify/notification.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/fs/notify/notification.c b/fs/notify/notification.c index 959b73e..69391fe 100644 --- a/fs/notify/notification.c +++ b/fs/notify/notification.c @@ -136,10 +136,15 @@ static bool event_compare(struct fsnotify_event *old, struct fsnotify_event *new { if ((old->mask == new->mask) && (old->to_tell == new->to_tell) && - (old->data_type == new->data_type)) { + (old->data_type == new->data_type) && + (old->name_len == new->name_len)) { switch (old->data_type) { case (FSNOTIFY_EVENT_INODE): - if (old->inode == new->inode) + /* remember, after old was put on the wait_q we aren't + * allowed to look at the inode any more, only thing + * left to check was if the file_name is the same */ + if (old->name_len && + !strcmp(old->file_name, new->file_name)) return true; break; case (FSNOTIFY_EVENT_PATH): |
