diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2011-01-02 21:56:36 -0500 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2011-01-04 16:49:22 -0500 |
| commit | 9e701c610923aaeac8b38b9202a686d1cc9ee35d (patch) | |
| tree | 1b2d65df63858a2cd35a4154e6d8a9fea3e716a3 /fs/nfsd | |
| parent | d76d1815f3e72fb627ad7f95ef63120b0a557c9c (diff) | |
| download | op-kernel-dev-9e701c610923aaeac8b38b9202a686d1cc9ee35d.zip op-kernel-dev-9e701c610923aaeac8b38b9202a686d1cc9ee35d.tar.gz | |
svcrpc: simpler request dropping
Currently we use -EAGAIN returns to determine when to drop a deferred
request. On its own, that is error-prone, as it makes us treat -EAGAIN
returns from other functions specially to prevent inadvertent dropping.
So, use a flag on the request instead.
Returning an error on request deferral is still required, to prevent
further processing, but we no longer need worry that an error return on
its own could result in a drop.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd')
| -rw-r--r-- | fs/nfsd/nfssvc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index 2bae1d8..18743c4 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -608,7 +608,7 @@ nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp) /* Now call the procedure handler, and encode NFS status. */ nfserr = proc->pc_func(rqstp, rqstp->rq_argp, rqstp->rq_resp); nfserr = map_new_errors(rqstp->rq_vers, nfserr); - if (nfserr == nfserr_dropit) { + if (nfserr == nfserr_dropit || rqstp->rq_dropme) { dprintk("nfsd: Dropping request; may be revisited later\n"); nfsd_cache_update(rqstp, RC_NOCACHE, NULL); return 0; |
