summaryrefslogtreecommitdiffstats
path: root/fs/nfs
diff options
context:
space:
mode:
authorPeng Tao <tao.peng@primarydata.com>2014-10-10 23:25:46 +0800
committerTom Haynes <loghyr@primarydata.com>2015-02-03 11:06:47 -0800
commit566f8737630390b743d79e26e4ac855fe2758129 (patch)
tree974b19ea87f8185b4442657a51a0ce27fc70998c /fs/nfs
parent80c76fe314c2859d5aac94b5d66d2b9895aa73d4 (diff)
downloadop-kernel-dev-566f8737630390b743d79e26e4ac855fe2758129.zip
op-kernel-dev-566f8737630390b743d79e26e4ac855fe2758129.tar.gz
nfs41: add a debug warning if we destroy an unempty layout
So that we can detect the case if some layout segments are still pinned which is surely a bug that we need to fix. Signed-off-by: Peng Tao <tao.peng@primarydata.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r--fs/nfs/pnfs.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 5f7c422..e123cfc 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -242,6 +242,8 @@ pnfs_put_layout_hdr(struct pnfs_layout_hdr *lo)
struct inode *inode = lo->plh_inode;
if (atomic_dec_and_lock(&lo->plh_refcount, &inode->i_lock)) {
+ if (!list_empty(&lo->plh_segs))
+ WARN_ONCE(1, "NFS: BUG unfreed layout segments.\n");
pnfs_detach_layout_hdr(lo);
spin_unlock(&inode->i_lock);
pnfs_free_layout_hdr(lo);
OpenPOWER on IntegriCloud