summaryrefslogtreecommitdiffstats
path: root/fs/nfs
diff options
context:
space:
mode:
authorFred Isaman <fred.isaman@gmail.com>2016-09-27 15:37:11 -0400
committerTrond Myklebust <trond.myklebust@primarydata.com>2016-12-01 17:21:38 -0500
commit9a837856cf612d83e9ede7081972a2fa78de6921 (patch)
treedd61dc7c4c956a3fb3db08dcf3f0192d0d0b6e7b /fs/nfs
parent1ad13dbc85911fcf15232342205c92e250335267 (diff)
downloadop-kernel-dev-9a837856cf612d83e9ede7081972a2fa78de6921.zip
op-kernel-dev-9a837856cf612d83e9ede7081972a2fa78de6921.tar.gz
NFSv4.1: Fix regression in callback retry handling
When initializing a freshly created slot for the calllback channel, the seq_nr needs to be 0, not 1. Otherwise validate_seqid and nfs4_slot_wait_on_seqid get confused and believe that the mpty slot corresponds to a previously sent reply. Signed-off-by: Fred Isaman <fred.isaman@gmail.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r--fs/nfs/nfs4session.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/nfs4session.c b/fs/nfs/nfs4session.c
index a61350f..769b856 100644
--- a/fs/nfs/nfs4session.c
+++ b/fs/nfs/nfs4session.c
@@ -169,7 +169,7 @@ bool nfs4_try_to_lock_slot(struct nfs4_slot_table *tbl, struct nfs4_slot *slot)
struct nfs4_slot *nfs4_lookup_slot(struct nfs4_slot_table *tbl, u32 slotid)
{
if (slotid <= tbl->max_slotid)
- return nfs4_find_or_create_slot(tbl, slotid, 1, GFP_NOWAIT);
+ return nfs4_find_or_create_slot(tbl, slotid, 0, GFP_NOWAIT);
return ERR_PTR(-E2BIG);
}
OpenPOWER on IntegriCloud