summaryrefslogtreecommitdiffstats
path: root/fs/nfs
diff options
context:
space:
mode:
authorTrond Myklebust <trond.myklebust@primarydata.com>2017-01-23 22:44:12 -0500
committerTrond Myklebust <trond.myklebust@primarydata.com>2017-01-23 22:44:12 -0500
commit8ac092519ad91931c96d306c4bfae2c6587c325f (patch)
treece2a134fdbed539f535f1b5a63cd5bdbc264965b /fs/nfs
parent7a308bb3016f57e5be11a677d15b821536419d36 (diff)
downloadop-kernel-dev-8ac092519ad91931c96d306c4bfae2c6587c325f.zip
op-kernel-dev-8ac092519ad91931c96d306c4bfae2c6587c325f.tar.gz
NFSv4.1: Fix a deadlock in layoutget
We cannot call nfs4_handle_exception() without first ensuring that the slot has been freed. If not, we end up deadlocking with the process waiting for recovery to complete, and recovery waiting for the slot table to drain. Fixes: 2e80dbe7ac51 ("NFSv4.1: Close callback races for OPEN, LAYOUTGET...") Cc: stable@vger.kernel.org # v4.8+ Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r--fs/nfs/nfs4proc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index ecc1516..59bb574 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -8490,6 +8490,7 @@ nfs4_layoutget_handle_exception(struct rpc_task *task,
goto out;
}
+ nfs4_sequence_free_slot(&lgp->res.seq_res);
err = nfs4_handle_exception(server, nfs4err, exception);
if (!status) {
if (exception->retry)
OpenPOWER on IntegriCloud